-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve mscolab for configure multiple Idps #2043
improve mscolab for configure multiple Idps #2043
Conversation
Disabled pytests for GSoC branch with Todo Refactor cause of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments.
Please re-enable the test workflow. If the PR in its current state does not pass I would prefer to see that, instead of seeing "All checks have passed" with a check missing.
This might have been a fluke anyway, I ran the test suite locally and it passed. I also started a re-run of the job (see: https://github.com/Open-MSS/MSS/actions/runs/6456242735/job/17637454977); let's see if that makes it through. This happens sometimes, unfortunately...
Edit: OK, the re-run didn't make it either, but it failed in a different test function this time...
Edit Edit: exit code 137 indicates that the job is cancelled because of high memory usage, the runner is running out of memory. It looks like there is a memory leak somewhere. That also explains why it did pass on my system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left another comment. Apart from that this looks good to me.
I could not yet figure out why the CI runs fail. Locally I could not reproduce the issue, even if I limit the pytest run to 100M of RAM with:
systemd-run --scope -p MemoryMax=100M --user -- pytest -v --durations=20 --reverse --cov=mslib tests
According to githubs docs the runner should have 7GB of RAM available. So, no idea what's the issue.
@ReimarBauer advised to not spend to much time debugging this issue, so I'll approve this with the caveat of the one comment. I'll also run the workflow again to make sure it wasn't two flukes in a row...
f94da54
into
Open-MSS:GSOC2023-NilupulManodya
Purpose of PR?:
The purpose of this PR is to improve the mscolab server, enabling it to support multiple IdPs. In this PR, have made necessary functional improvements and error handling enhancements for this purpose
may be better to review Draft Developer doc https://docs.google.com/document/d/1fX7F4KYQ-iIibvMjSqF0oInse-ew2naJ_ataqylNU8Q/edit?usp=sharing before reviewing this PR
Fixes #
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:
<type>: <subject>