-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cycle login with multiple_flightpath_dockwidget #2278
Conversation
A further test which enables multiple operations is needed |
seems that would need a wider refactoring. This could be part of a GSOC project or later a new issue. We should have a class for collecting the data and all QT elements and related methods in the MultipleFlightpathControlWidget for using the data. Currently that is mixed. By the current design the control qt elements of the different operations can't be accessed over the parent. That means also they can't be used for tests or tutorials, because they can't be searched. |
So, by this you mean for now we don't need to worry about the test and for now just focus on having a class for collecting the data and all QT elements and related methods in the |
We need more tests. The tests define the later solution. When we know the reason a test now fails we set it to xfail. The tests should describe first what we expect. Then when we see the picture we can do the refactoring. |
… and selected operations
Visual the test results on a "slow" CPU verified. Some ToDo's added |
Purpose of PR?:
Fixes #2037
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:
<type>: <subject>