Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cycle login with multiple_flightpath_dockwidget #2278

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

ReimarBauer
Copy link
Member

Purpose of PR?:

Fixes #2037

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes

Checklist:

@ReimarBauer ReimarBauer marked this pull request as draft March 12, 2024 18:06
@ReimarBauer
Copy link
Member Author

A further test which enables multiple operations is needed

@ReimarBauer
Copy link
Member Author

ReimarBauer commented Mar 13, 2024

A further test which enables multiple operations is needed

seems that would need a wider refactoring. This could be part of a GSOC project or later a new issue.

We should have a class for collecting the data and all QT elements and related methods in the MultipleFlightpathControlWidget for using the data. Currently that is mixed.

By the current design the control qt elements of the different operations can't be accessed over the parent. That means also they can't be used for tests or tutorials, because they can't be searched.

The gifcycle shows the problem.
problem_for_a_tutorial

@rohit2p
Copy link
Contributor

rohit2p commented Mar 13, 2024

seems that would need a wider refactoring. This could be part of a GSOC project or later a new issue.

So, by this you mean for now we don't need to worry about the test and for now just focus on having a class for collecting the data and all QT elements and related methods in the MultipleFlightpathControlWidget for using the data ??

@ReimarBauer
Copy link
Member Author

ReimarBauer commented Mar 14, 2024

We need more tests. The tests define the later solution. When we know the reason a test now fails we set it to xfail.
When the code gets improved it can be checked with the tests.

The tests should describe first what we expect. Then when we see the picture we can do the refactoring.
I assume we find some more problems or get ideas what is missing.

@ReimarBauer ReimarBauer requested a review from matrss March 20, 2024 19:11
@ReimarBauer ReimarBauer marked this pull request as ready for review March 20, 2024 19:11
@ReimarBauer
Copy link
Member Author

Visual the test results on a "slow" CPU verified. Some ToDo's added

tests/_test_msui/test_mscolab.py Outdated Show resolved Hide resolved
tests/_test_msui/test_mscolab.py Outdated Show resolved Hide resolved
tests/_test_msui/test_mscolab.py Show resolved Hide resolved
tests/_test_msui/test_mscolab.py Outdated Show resolved Hide resolved
@ReimarBauer ReimarBauer merged commit af73526 into Open-MSS:develop Mar 21, 2024
5 checks passed
@ReimarBauer ReimarBauer deleted the i2037b branch March 21, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple flightpath docking widget does not clear all topviews
3 participants