Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Multiple flightpath dockingwidget updates only local new flighpathes #2313

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

rohit2p
Copy link
Contributor

@rohit2p rohit2p commented Apr 9, 2024

Purpose of PR?:
I am able to reproduce the error (e.g., KeyError: 10, AttributeError: 'NoneType' object has no attribute 'all_waypoint_data') by creating or deleting operations, followed by attempting to switch operations. Sometimes the error does occurs but sometimes if i do sometime differently it doesn't occurs. In this PR i am trying to figure out the bug and fix it.

Fixes #2269

Checklist:

@rohit2p
Copy link
Contributor Author

rohit2p commented Apr 13, 2024

@ReimarBauer @matrss Can you plz take a look, In case of tests I am not able to reproduce the key error? what am i doing wrong?

@ReimarBauer
Copy link
Member

@rohit2p I merged the other one, so we have now conflicts here.

@rohit2p
Copy link
Contributor Author

rohit2p commented Apr 15, 2024

@ReimarBauer when i debug test_operation_while_switching_error while switching between operations i should be able to get the error, then why i am not getting it ? can you help me a bit please

@ReimarBauer
Copy link
Member

when I look on test_operation_while_switching_error this does compared to the description the actions differently.

In the description the topview with the dockingwidget is opened and then the login is done. In the test you start with a login.

@rohit2p
Copy link
Contributor Author

rohit2p commented Apr 17, 2024

@ReimarBauer see even with that the Key error is not happening during testing

@rohit2p
Copy link
Contributor Author

rohit2p commented Apr 17, 2024

I think if i create a new operation or delete an old operations after login on top of the old operations and then switch between operations. In this case I'll be able to catch the error but when i try creating an operation after login. It doesn't reflect in the UI of MsColab operations section

@joernu76
Copy link
Member

joernu76 commented Jul 2, 2024

The code is clean and it works nicely!

Close to being mergeable.

  1. Wrt to the Options: You added a group for "flightpath" options in the TV/SV Options. I would say that both flightpath colour should be moved there as well. Maybe the tickbox "draw flightpath" in there and move the colour options there as well.

  2. I also suggest to have a fully identical layout of this box in TV and SV.

  3. Also, on my screen, the SV flightpath option box is not fully visible:
    Screenshot at 2024-07-02 11-02-04
    I think, this should be solvable using some of the QT options. There is still some space left on my screen for this purpose.

  4. The TV box has the "Flight path option" label. The "Plot options" label is above the box. I suggest to handle this in a consistent fashion by having all these labels outside above the box:
    Screenshot at 2024-07-02 11-03-54

  5. Not necessarily for this PR. I find it confusing that when I can select the "active" flighttrack that the controls vanish and I cannot disable the tickbox. Ideally, this element should be "disabled" in QT such that it cannot be clicked and is visually marked as inactive.

  6. Not necessarily for this project: When opening the box, all flightpaths are seemingly loaded from MSCOlab. I would suggest to do this in a lazy fashion only for selected flightpaths. Opening it takes an astonishing long time on our PHILEAS server; the user might think that the app has crashed as there is no loading splash screen or similar.

nice!

@joernu76 joernu76 marked this pull request as ready for review July 4, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

develop: multiple flightpath dockingwidget updates only local new flighpathes
3 participants