Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to miniforge #20

Merged
merged 19 commits into from
Feb 22, 2024
Merged

update to miniforge #20

merged 19 commits into from
Feb 22, 2024

Conversation

ReimarBauer
Copy link
Member

No description provided.

@ReimarBauer ReimarBauer marked this pull request as draft December 8, 2023 15:32
@ReimarBauer
Copy link
Member Author

A similar problem is shown on mamba-org/mamba#3044

@ReimarBauer ReimarBauer linked an issue Dec 8, 2023 that may be closed by this pull request
@ReimarBauer
Copy link
Member Author

ReimarBauer commented Dec 8, 2023

  • manual linux installation succeeds.
  • manual windows installation succeeds

@ReimarBauer ReimarBauer marked this pull request as ready for review December 12, 2023 11:03
@ReimarBauer
Copy link
Member Author

tested on a guacamole win setup and a new linux user

Copy link

@matrss matrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some missed action updates, otherwise this looks good to me. I didn't test locally though, but CI says it's good.

When squashing please clean up the commit message, otherwise the git log becomes an incomprehensible mess.

@@ -76,16 +76,16 @@ jobs:
steps:
- uses: actions/checkout@v3
Copy link

@matrss matrss Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v3
- uses: actions/checkout@v4

Since you have changed it in the other jobs as well.

.github/workflows/test_installer.yml Outdated Show resolved Hide resolved
.github/workflows/test_installer.yml Outdated Show resolved Hide resolved
.github/workflows/test_installer.yml Outdated Show resolved Hide resolved
@ReimarBauer ReimarBauer merged commit 5ecfcf9 into main Feb 22, 2024
@ReimarBauer ReimarBauer deleted the i18b branch February 22, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mambaforge (Discouraged as of September 2023)
2 participants