Support multiple arguments. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R1kaB3rN
added a commit
that referenced
this pull request
Jun 14, 2024
- Currently, winetricks verbs are being applied to the wine prefix by executing the winetricks script as an executable for Proton. For some reason, this results in system calls failing for container binaries such as grep and sed, which are required by winetricks for parsing. Here's an example of grep's coredump: Stack trace of thread 52329: #0 0x000070003275383b n/a (/lib/ld-linux-x86-64.so.2 + 0x2183b) #1 0x000070003274e0f8 n/a (/lib/ld-linux-x86-64.so.2 + 0x1c0f8) #2 0x000070003274f9be n/a (/lib/ld-linux-x86-64.so.2 + 0x1d9be) #3 0x000070003274e748 n/a (/lib/ld-linux-x86-64.so.2 + 0x1c748) ELF object binary architecture: AMD x86-64 While this doesn't appear to impact the application of winetricks verbs to the prefix nor has there been reports of this problem yet, as a precaution, we should set these environment variables from the proton script and replicate protonfixes' execution. As a result, theere should be no more coredumps except from wine64-preloader, which should be normal, and the launcher will only guard against valid winetricks verbs
R1kaB3rN
added a commit
that referenced
this pull request
Jun 30, 2024
* umu_run: remove winetricks environment variables - Currently, winetricks verbs are being applied to the wine prefix by executing the winetricks script as an executable for Proton. For some reason, this results in system calls failing for container binaries such as grep and sed, which are required by winetricks for parsing. Here's an example of grep's coredump: >Stack trace of thread 52329: >\#0 0x000070003275383b n/a (/lib/ld-linux-x86-64.so.2 + 0x2183b) >#1 0x000070003274e0f8 n/a (/lib/ld-linux-x86-64.so.2 + 0x1c0f8) >#2 0x000070003274f9be n/a (/lib/ld-linux-x86-64.so.2 + 0x1d9be) >#3 0x000070003274e748 n/a (/lib/ld-linux-x86-64.so.2 + 0x1c748) >ELF object binary architecture: AMD x86-64 While this doesn't appear to impact the application of winetricks verbs to the prefix nor has there been reports of this problem yet, as a precaution, we should set these environment variables from the proton script and replicate protonfixes' execution. As a result, theere should be no more coredumps except from wine64-preloader, which should be normal, and the launcher will only guard against valid winetricks verbs * umu_test: update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run this:
only
/unixget passed to the final script.