fix: use $HOME/.local/share/umu and $XDG_CACHE_HOME for flatpak #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R1kaB3rN
changed the title
imLinguin
reviewed
Oct 14, 2024
- Prefer conforming to the XDG Base Directory Specification when possible for our cache directory
imLinguin
reviewed
Oct 14, 2024
R1kaB3rN
force-pushed
the
flatpak-host-local-share-umu
branch
from
4a45e5d
to
48c4918
Compare
strycore
approved these changes
Oct 14, 2024
strycore
pushed a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralizes the installation path of umu for both Flatpak and native applications in $HOME/.local/share/umu. This change will prevent cases like flathub/net.lutris.Lutris#440 where the meaning of ~/.var/app/org.openwinecomponents.umu.umu-launcher/data/umu changes when the host's home directory is exposed.
Flatpaks will be required to change their manifest to allow read-write access to the host ~/.local/share/umu.
Closes #230