Fix CMake Deprecation Warnings #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building OpenAMP for standalone ARM R5, the following warning occurs: CMake Deprecation Warning at /usr/share/cmake-3.16/Modules/CMakeForceCompiler.cmake:75 (message): The CMAKE_FORCE_C_COMPILER macro is deprecated. Instead just set CMAKE_C_COMPILER and allow CMake to identify the compiler. Call Stack (most recent call first): cmake/platforms/cross_generic_gcc.cmake:5 (CMAKE_FORCE_C_COMPILER) /home/mooring/build-oa/toolchain.r5-oa.sa:18 (include) /usr/share/cmake-3.16/Modules/CMakeDetermineSystem.cmake:93 (include) CMakeLists.txt:19 (project) Follow the suggestions in the above error message, and add CMAKE_TRY_COMPILE_TARGET_TYPE = STATIC LIBRARY, which makes try_compile() not try to link the cross-compiled binary. This is necessary because the arm-none-eabi toolchain libgcc doesn't have an implementation of _exit(), leaving that to the BSP. This results in a CMake error because it can't build the test executable. Signed-off-by: Ed Mooring <[email protected]>
arnopo
approved these changes
May 12, 2022
|
Yes I do.
… On May 12, 2022, at 8:27 AM, Arnaud Pouliquen ***@***.***> wrote:
@arnopo approved this pull request.
LGTM
Do you plan to also provide same fix for the libmetal?
—
Reply to this email directly, view it on GitHub <#389 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYOVHEOLCKTSPJ2USP2WITVJUPO3ANCNFSM5VJW427Q>.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building OpenAMP for standalone ARM R5, the following warning occurs:
CMake Deprecation Warning at
/usr/share/cmake-3.16/Modules/CMakeForceCompiler.cmake:75 (message):
The CMAKE_FORCE_C_COMPILER macro is deprecated. Instead just set
CMAKE_C_COMPILER and allow CMake to identify the compiler.
Call Stack (most recent call first):
cmake/platforms/cross_generic_gcc.cmake:5 (CMAKE_FORCE_C_COMPILER)
/home/mooring/build-oa/toolchain.r5-oa.sa:18 (include)
/usr/share/cmake-3.16/Modules/CMakeDetermineSystem.cmake:93 (include)
CMakeLists.txt:19 (project)
Follow the suggestions in the above error message, and add
CMAKE_TRY_COMPILE_TARGET_TYPE = STATIC LIBRARY, which makes try_compile()
not try to link the cross-compiled binary. This is necessary because the
arm-none-eabi toolchain libgcc doesn't have an implementation of _exit(),
leaving that to the BSP. This results in a CMake error because it can't
build the test executable.
Signed-off-by: Ed Mooring [email protected]