Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add include directory to open_amp-static target #545

Conversation

zaporozhets
Copy link
Contributor

Hi,

The following PR adds include directory in the open_amp-static target, enabling building and linking static library using CMake subdirectory. This allows to have open_amp library as git submodule and build it with the parent project as cmake dependency.

For example:

add_subdirectory(open-amp)


target_link_libraries(main_app
    PUBLIC
    open_amp-static
)

Let me know if you have any suggestions on the target name or better ideas on implementation.

Include a header directory in the open_amp-static target, enabling
building and linking static library using CMake subdirectory.

Signed-off-by: Taras Zaporozhets <[email protected]>
@zaporozhets zaporozhets changed the title lib: Add include directory to open_amp-static target lib: add include directory to open_amp-static target Dec 27, 2023
Copy link
Collaborator

@tnmysh tnmysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me.

Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@arnopo arnopo merged commit 1957ed2 into OpenAMP:main Jan 4, 2024
3 checks passed
@arnopo arnopo added this to the Release V2024.04 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants