apps: linux: generic: Use accessor functions for struct remoteproc_mem #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnopo
requested changes
Mar 14, 2024
Yes, here let me add a couple more to this series. |
glneo
force-pushed
the
apps-remoteproc-mem
branch
2 times, most recently
from
b7b23c3
to
e347711
Compare
arnopo
requested changes
Mar 18, 2024
The remoteproc_mem struct contents are internal to remoteproc. The struct should be accessed using the provided accessors, not directly. This is done in preparation of making this struct opaque to code outside of the remoteproc drivers. Signed-off-by: Andrew Davis <[email protected]>
The remoteproc_mem and rproc structs contents are internal to remoteproc. These should be accessed using the provided accessors, not directly. This is done in preparation of making these struct opaque to code outside of the remoteproc drivers. Signed-off-by: Andrew Davis <[email protected]>
The memory list is already initialized before this callback is called. Remove this redundant initialization. Signed-off-by: Andrew Davis <[email protected]>
glneo
force-pushed
the
apps-remoteproc-mem
branch
from
e347711
to
408e698
Compare
arnopo
approved these changes
Mar 19, 2024
|
@tanmays, @bentheredonethat |
|
yes LGTM |
tnmysh
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remoteproc_mem struct contents are internal to remoteproc. The struct should be accessed using the provided accessors, not directly. This is done in preperation of making this struct opaque to code outside of the remoteproc drivers.