virtqueue: Fix comment on shm_io and fix type #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnopo
reviewed
Mar 25, 2024
danmilea
reviewed
Mar 27, 2024
The metal_io_region in the virtqueue struct is for translating the buffer address stored in the virtqueue descriptor table, not the address of the descriptor table itself. This may have worked previously if the vring descriptors where part of the same IO space as the buffers they point to, but this is not guaranteed to always be the case. Fix that here. Signed-off-by: Andrew Davis <[email protected]>
This should hold a pointer to a metal_io_region, make that the type. Also fix the comment above this variable. This region holds the address of the message buffers, not the vring descriptor table nor available/used ring data. It is only used for virt-to-phys/phys-to-vert translation on the buffers pointed to by these descriptors. Signed-off-by: Andrew Davis <[email protected]>
arnopo
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hold a pointer to an metal_io_region, make that the type.
Also fix the comment, this region holds the address of the message buffers, not the vring's descriptor table nor available/used rings. It is only used for virt-to-phys/phys-to-vert on the buffers pointed to by these descriptors.
This comment seems to have cause an issue in virtio_mmio_drv where this region was used to translate the address of the vring descriptors. This may have worked if the vring descriptors where part of the same IO space as the buffers they point to, but this is not guaranteed to always be the case. Fix that here.