-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] nullable attribute with value null gets removed #2199
Comments
@githubERIK thanks for reporting the issue and sharing the workaround. But I think in certain use cases, the workaround may introduce additional null values in the payload, which are not present before. I think we may need to maintain another associative array similar to openAPITypes to indicate if the property is nullable |
@githubERIK does my comment earlier make sense to you? |
The comment makes sense. For nullables in model_generic.mustache,
could be added and then accessed. |
Things to keep in mind. When a request goes out
When a response comes in
|
API platform supports partial PUT operations: omitting a field in the request does not clear the value on PUT operations. So I'm wondering, the change discussed here, how would the client distinguish nullable fields explicitly set to null versus fields omitted in the payload? I believe this question is especially important because the client does not support PATCH requests. |
Hi ! |
Description
Given a nullable field in OpenAPI object
When HTTP Request has the object and it includes
someProperty=null
.Then the generated php client code does not include
someProperty
in the response.openapi-generator version
master branch (version 3.3.4)
EDIT: also version 4.0.3
OpenAPI declaration file content or url
See the description
Command line used for generation
openapi-generator generate -g php
Steps to reproduce
Related issues/PRs
Suggest a fix/enhancement
Remove null-check if-block
if ($value !== null)
from https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/php/ObjectSerializer.mustache#L68by changing this
to this
The text was updated successfully, but these errors were encountered: