Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rails5] Ruby on Rails stub server requires MySQL but does not use it #254

Closed
ledsun opened this issue Jun 8, 2018 · 5 comments
Closed

Comments

@ledsun
Copy link
Contributor

ledsun commented Jun 8, 2018

Description

The Ruby on Rails stub server requires MySQL.
Its Gemfile includes line blew:

# Use mysql as the database for Active Record
gem 'mysql2', '>= 0.3.18', '< 0.5'

To start the Ruby on Rails stub server, we need to install MySQL in the development environment.
However, the Ruby on Rails stub server does not use the database.
I think this is a meaningless cost.

openapi-generator version

3.0.0

OpenAPI declaration file content or url

Any.

Command line used for generation
bin/rails5-petstore-server.sh
Steps to reproduce
bin/rails5-petstore-server.sh
Related issues/PRs

No.

Suggest a fix/enhancement

Switch the database to SQLite for Ruby on Rails stub server like:
https://github.com/ledsun/openapi-generator/tree/rails_reduce_dependency

We can start the Ruby on Rails stub server in fewer steps.

@wing328
Copy link
Member

wing328 commented Jun 8, 2018

@ledsun thanks for reporting the issue. I agree with you SQLite works better for new users who use the auto-generated Ruby-on-Rails app for the first time.

May I know if you've time to contribute a PR with the enhancement?

@ledsun
Copy link
Contributor Author

ledsun commented Jun 11, 2018

I can create a PR today or tomorrow.

@wing328 wing328 modified the milestones: 3.0.1, 3.0.2 Jun 11, 2018
@jmini jmini modified the milestones: 3.0.2, 3.0.3 Jun 18, 2018
@ackintosh ackintosh modified the milestones: 3.0.3, 3.1.0 Jun 27, 2018
@ackintosh
Copy link
Contributor

Changed to '3.1.0' as #279 is planed to release in v3.1.0.

@ackintosh
Copy link
Contributor

@ledsun The enhancement is merged into 3.1.0 branch. ✨ can we close this issue?

@wing328
Copy link
Member

wing328 commented Jun 29, 2018

Sure.

@wing328 wing328 closed this as completed Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants