Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate MySQL dependency of Rails 5 stub server #279

Merged
merged 2 commits into from
Jun 17, 2018

Conversation

ledsun
Copy link
Contributor

@ledsun ledsun commented Jun 11, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@cliffano @zlx

Description of the PR

I change a database from MySQL to SQLite, In order to make setup of the Rails 5 stub server easy.
Close #254

@wing328 wing328 added this to the 3.1.0 milestone Jun 11, 2018
@wing328 wing328 changed the base branch from master to 3.1.x June 13, 2018 04:45
@wing328 wing328 merged commit 86a82d1 into OpenAPITools:3.1.x Jun 17, 2018
@wing328
Copy link
Member

wing328 commented Jun 17, 2018

@ledsun thanks for the PR, which has been merged into 3.1.x as it's breaking change with fallback (customizing templates).

I'll add an option to customize the database adapter so that we can support more DB adapter (e.g. MongoDB) in the future.

@wing328
Copy link
Member

wing328 commented Aug 2, 2018

@ledsun thanks again for your PR. Unfortunately it was accidentally rolled back by 478b0d6#diff-90d5857423d585a1e3ca4d42fcc050f4

I've filed #711 to add back your changes and add an option to select "mysql" or "sqlite" (default).

Please kindly take a look when you've time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants