Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #1

Merged
merged 14 commits into from
May 12, 2018
Merged

Various fixes #1

merged 14 commits into from
May 12, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 12, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Various fixes reported by the CI.

@wing328 wing328 added this to the 3.0.0 milestone May 12, 2018
<!-- clients -->
<!-- elm client not fully ready for CI yet
<module>samples/client/petstore/elm</module>-->
<module>samples/client/petstore/groovy</module>
<module>samples/client/petstore/rust</module>
<module>samples/client/petstore/perl</module>
<!--<module>samples/client/petstore/perl</module>-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this pom match the circlci poms? The go client is commented there and perl is commented here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question but they should not be the same as different CIs should test different clients/servers.

@wing328
Copy link
Member Author

wing328 commented May 12, 2018

The issues reported by CircleCI will be handled in another PR.

@wing328 wing328 merged commit 1d889da into master May 12, 2018
@wing328 wing328 deleted the first_fix branch May 12, 2018 17:58
wing328 pushed a commit that referenced this pull request May 28, 2018
* Make SwaggerCodeGen serialize subclasses properly (PHNX-859) (#1)

Motivation
----
Previously, when serializing as subclass of a property, generated swagger clients would only serialize properties of the parent class causing some values to not be pass through

Modifications
----
Before serializing attributes of a given type, we check to see if there is a specific type to be serialized so that we don't miss any properties.

* Fix improper whitespace in mustache template (PHNX-859) (#2)

Motivation
----
OpenAPI Generator upstream requested whitespace fixes (from tabs to 4 spaces)

Modifications
----
Fixed whitespace
wing328 pushed a commit that referenced this pull request Aug 27, 2018
* Kotlin Spring initial bootstrap

* Basic configuration construction for Kotlin Spring

* Wired up with comand line client

* Initial kotlin spring boot application generated using gradle kotlin-dsl

* Added basic support for generating models

* Basic controllers generated without endpoints generated

* Basic spring boot app generated with models and controllers

* Added fix for type mapping in AbstractKotlinCodegen. Originally it was mapping list o kotlin.Array instead of kotlin.collections.List

* Fixed return type mapping

* Sorted bash springboot petstore generator script

* Implemented toVarName in AbstractKotlinCodegen to better handle some edgecases

* Checking for reserved words or numerical starting class names in AbstractKotlinCodegen

* Implemented toOperationId in AbstractKotlinCodegen

* Fixed types that were not correctly being mapped to primitives (byte / arrayOf / mapOf)

* Escaping dollar symbols in function names

* Added support for outter enum classes

* Added basic support for generating services

* Removed option for generated config package. Added option to enable/disable generated global exception handler

* Added configuration option to generate gradle. Generated maven pom.xml file as default

* Fixed up bash scripts for generating test sample code

* Added configurable option for Swagger Annotations

* Added configurable option for generating service interfaces and service implementations

* Added README generation

* Enable optional bean validation

* Added kotlin spring sample to CircleCI pom.xml

* Removed kotlin spring boot from .gitignore

* Minor fixes from PR comments for user submission (#1)

* Minor fixes from PR comments for user submission

* Puts braces around conditional block bodies with one-liner bodies.
* Modifies README.mustache to use artifact id and version supplied by
user (or default configuration)
* Targets templates under resource directory explicitly to prevent the
need to rebuild for evaluation of  template-only changes.

* [kotlin-spring] Remove comments referencing sbt in bash scripts

* List of changes based upon code review:
* Additional comments around how we set the title based off the open api spec
* Fixed missing `beanValidationCore` template
* Put the lambdas into the lambda object as other generators do (Ktor, C#, cpp)
* Bump swagger-annotations version to latest pre-2.0 version (1.5.21)
* Set kotlin version to 1.2.60
* Updated README to set port based on template
* Added more additional properties to build bash scripts
* Removed `defaultBasePath.mustache` in place of using {{contextPath}} directly
* Log warning for when `serviceImplementation` is set t o true

* Updated samples

* Generating ConstraintViolation Exception Handler, as Springboot doesnt correctly catch the error and return bad request. Handling other exceptions a litle better

* Small fix for date time mappings (plus sample re-gen)

* Minor fix in README template, where port was using wrong variable

* Fix missing jackson-dataformat-xml dependency

* Fix build - needed to re-run kotlin-server-petstore.sh

* Fixes after merge with master

* Revert "Small fix for date time mappings (plus sample re-gen)"

This reverts commit 4152dc78b4813da71c675272ca90fb31a333aea1.

* Moved type mappings to Kotlin Spring generator

* Regenerated samples

* Regenerated samples
wing328 pushed a commit that referenced this pull request Jan 25, 2019
Bring my fork up to date with base
A-Joshi referenced this pull request in ihsmarkitoss/openapi-generator Feb 27, 2019
* Kotlin Spring initial bootstrap

* Basic configuration construction for Kotlin Spring

* Wired up with comand line client

* Initial kotlin spring boot application generated using gradle kotlin-dsl

* Added basic support for generating models

* Basic controllers generated without endpoints generated

* Basic spring boot app generated with models and controllers

* Added fix for type mapping in AbstractKotlinCodegen. Originally it was mapping list o kotlin.Array instead of kotlin.collections.List

* Fixed return type mapping

* Sorted bash springboot petstore generator script

* Implemented toVarName in AbstractKotlinCodegen to better handle some edgecases

* Checking for reserved words or numerical starting class names in AbstractKotlinCodegen

* Implemented toOperationId in AbstractKotlinCodegen

* Fixed types that were not correctly being mapped to primitives (byte / arrayOf / mapOf)

* Escaping dollar symbols in function names

* Added support for outter enum classes

* Added basic support for generating services

* Removed option for generated config package. Added option to enable/disable generated global exception handler

* Added configuration option to generate gradle. Generated maven pom.xml file as default

* Fixed up bash scripts for generating test sample code

* Added configurable option for Swagger Annotations

* Added configurable option for generating service interfaces and service implementations

* Added README generation

* Enable optional bean validation

* Added kotlin spring sample to CircleCI pom.xml

* Removed kotlin spring boot from .gitignore

* Minor fixes from PR comments for user submission (#1)

* Minor fixes from PR comments for user submission

* Puts braces around conditional block bodies with one-liner bodies.
* Modifies README.mustache to use artifact id and version supplied by
user (or default configuration)
* Targets templates under resource directory explicitly to prevent the
need to rebuild for evaluation of  template-only changes.

* [kotlin-spring] Remove comments referencing sbt in bash scripts

* List of changes based upon code review:
* Additional comments around how we set the title based off the open api spec
* Fixed missing `beanValidationCore` template
* Put the lambdas into the lambda object as other generators do (Ktor, C#, cpp)
* Bump swagger-annotations version to latest pre-2.0 version (1.5.21)
* Set kotlin version to 1.2.60
* Updated README to set port based on template
* Added more additional properties to build bash scripts
* Removed `defaultBasePath.mustache` in place of using {{contextPath}} directly
* Log warning for when `serviceImplementation` is set t o true

* Updated samples

* Generating ConstraintViolation Exception Handler, as Springboot doesnt correctly catch the error and return bad request. Handling other exceptions a litle better

* Small fix for date time mappings (plus sample re-gen)

* Minor fix in README template, where port was using wrong variable

* Fix missing jackson-dataformat-xml dependency

* Fix build - needed to re-run kotlin-server-petstore.sh

* Fixes after merge with master

* Revert "Small fix for date time mappings (plus sample re-gen)"

This reverts commit 4152dc78b4813da71c675272ca90fb31a333aea1.

* Moved type mappings to Kotlin Spring generator

* Regenerated samples

* Regenerated samples
turkeylurkey pushed a commit to turkeylurkey/openapi-generator that referenced this pull request Nov 14, 2019
* Create JavaMicroprofile generator

* Add ApiException and ApiExeptionMapper

* Add documentation for running the generator

* Update README

* Capitalize P in MicroProfile

* Clean up generated model for microprofile rest client

* Revert change in AbstractJavaCodegen and move the action into JavaMicroprofile

* Remove non-cxf templates in JavaMicroprofile and rename cxf to mp"

* Remove mp/server files

* Update pom.xml to have MpRestClient dependencies

* Generate tests using smallrye implementation

* Change JavaMicroprofile.java to JavaMicroprofileCodegen.java

* Add test for JavaMicroprofileCodegen

* Add scripts to generate petstore sample

* Add README

* Revert "Add scripts to generate petstore sample"

This reverts commit 25ee496.

* Revert "Add README"

This reverts commit 067b2a8.

* Revert "Revert "Add scripts to generate petstore sample""

This reverts commit 5a36390.

* Add README

* Move templates out of mp/ directory

* Remove CXF references

* Remove unnecessary templates

* Fix compilation errors

* Add missing jsonb dependency

* Add license header to code templates

* Increase copyright year to 2019

* Remove TODO comments and commented out code

* Add more javadocs to the model templates

* Fix issues with generated code

* Revert README back to master's README

* Add documentation for java microprofile client generator

* Add MicroProfile Rest Client to list of clients in README

* Remove smartbear copyright from java files

* Add disableMultipart option

* Fix licenseInfo

* Rename JavaMicroprofileCodegen to JavaMicroprofileRestClientCodegen

* Rename sample scripts to java-microprofile-rest-client

* Adjust test comments

* Better spacing between members for generated models

* Update getHelp() method

* Update javadoc for tests
nielspardon added a commit to nielspardon/openapi-generator that referenced this pull request Jul 24, 2020
wing328 pushed a commit that referenced this pull request Sep 28, 2020
Thecrazyskull pushed a commit to Thecrazyskull/openapi-generator that referenced this pull request Nov 13, 2020
Upgrade to kotlin 1.4 & bug fixes for kotlin MPP
Thecrazyskull pushed a commit to Thecrazyskull/openapi-generator that referenced this pull request Nov 13, 2020
wing328 pushed a commit that referenced this pull request Jan 5, 2021
christiancompton pushed a commit to christiancompton/openapi-generator that referenced this pull request Apr 27, 2021
wing328 pushed a commit that referenced this pull request Jun 9, 2021
wing328 pushed a commit that referenced this pull request Jan 2, 2022
Sync with latest openapi master
wing328 pushed a commit that referenced this pull request May 23, 2022
hanakslr pushed a commit to hanakslr/openapi-generator that referenced this pull request May 27, 2022
nilskuhn pushed a commit to nilskuhn/openapi-generator that referenced this pull request Apr 6, 2023
wing328 pushed a commit that referenced this pull request Jan 29, 2024
macjohnny added a commit that referenced this pull request Apr 22, 2024
macjohnny added a commit that referenced this pull request Apr 22, 2024
fire pushed a commit to V-Sekai/openapi-generator that referenced this pull request Jun 25, 2024
fix. Default string values now with "quotes"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants