Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Spring] OneOf base class not generated (#9981) #10009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rgranadosd
Copy link

@rgranadosd rgranadosd commented Jul 22, 2021

Fix 9981 and Fix 5381
Implemented OneOf for java spring library(server side).
We have found this issue and we want to contribute with this solution that works for us.
This are mostly the changes done on PR-5661(#5661) merged with the current master

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda

@rgranadosd
Copy link
Author

Please seems something is broken on the first step, could anyone review the CI/CD please

@ramzimaalej
Copy link
Contributor

@wing328 The .Net build seems to be broken here. Can you please take a look?

@rgranadosd
Copy link
Author

@wing328 The .Net build seems to be broken here. Can you please take a look?

Hi @wing328 do you need some help in order to solve this issue?

@wing328
Copy link
Member

wing328 commented Aug 23, 2021

cc @OpenAPITools/generator-core-team as the change impacts the default codegen.

@wing328
Copy link
Member

wing328 commented Aug 23, 2021

@wing328 The .Net build seems to be broken here. Can you please take a look?

Please ignore the appveyor build failure for the time being.

@wing328
Copy link
Member

wing328 commented Aug 23, 2021

Have you tried the oneOf model support in the java client generator (jersey2, native)? What about using the same implementations?

@rgranadosd
Copy link
Author

Hi @wing328, this approach was done at (#8091), and seems it's not working for another C# build issue. So, think both issues are trying to do the same, so maybe could be a good idea to close one ( I think the other is more advance) and review what is happening with this build step.
Please let us know, and if you need something just tell us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Spring] OneOf base class not generated
3 participants