Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Client: Add support for collectionFormat="multi" #11169

Conversation

isimluk
Copy link
Contributor

@isimluk isimluk commented Dec 21, 2021

Previously, rust-client generator disregarded collectionFormat property of multi-value parameters. Now we support following values in collectionFormat: "", "csv", "multi".

You can review changes this PR yield for fairly sizeable project at https://github.com/CrowdStrike/rusty-falcon/pull/33/files

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Previously, rust-client generator disregarded collectionFormat property of
multi-value parameters. Now we support following values in collectionFormat: "",
"csv", "multi".

You can review changes this creates for fairly sizable project at https://github.com/CrowdStrike/rusty-falcon/pull/33/files
@isimluk isimluk changed the title Rust Client: Support collectionFormat="multi" Rust Client: Add support for collectionFormat="multi" Dec 21, 2021
@wing328 wing328 added this to the 5.4.0 milestone Dec 29, 2021
@wing328
Copy link
Member

wing328 commented Dec 29, 2021

Tested locally with updated samples and the result is good. Thanks for the contribution.

(next time, please follow step 3 to update the samples so that the CI can verify the change)

@wing328 wing328 merged commit 08773a2 into OpenAPITools:master Dec 29, 2021
@isimluk
Copy link
Contributor Author

isimluk commented Dec 30, 2021

Thank You, @wing328.

@isimluk isimluk deleted the rust-client-missing-collectionFormat-multi branch December 30, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants