Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp-netcore] Fix: Add only first Authorization header #11325

Conversation

Anakael
Copy link
Contributor

@Anakael Anakael commented Jan 15, 2022

Apply fix from #11272 to httpclient library

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Anakael Anakael changed the title [csharp-netcore] Fix: Add only first Authorization header [WIP][csharp-netcore] Fix: Add only first Authorization header Jan 15, 2022
@Anakael Anakael force-pushed the pr/anakael/fix-csharp-core-duplicate-headers branch from 51d1d59 to bab1655 Compare January 15, 2022 09:35
@Anakael Anakael force-pushed the pr/anakael/fix-csharp-core-duplicate-headers branch from bab1655 to 8a0c6d2 Compare January 15, 2022 09:41
@Anakael Anakael changed the title [WIP][csharp-netcore] Fix: Add only first Authorization header [csharp-netcore] Fix: Add only first Authorization header Jan 15, 2022
@wing328 wing328 added this to the 5.4.0 milestone Jan 15, 2022
@wing328
Copy link
Member

wing328 commented Jan 15, 2022

cc @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)

@wing328
Copy link
Member

wing328 commented Jan 15, 2022

LGTM. Thanks for the fix.

@wing328 wing328 merged commit 1b6d0f8 into OpenAPITools:master Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants