Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Fix for form parameters (x-www-form-urlencoded) #1187

Merged

Conversation

beardeddragon5
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09)

Description of the PR

swagger-api/swagger-codegen#8767

@wing328
Copy link
Member

wing328 commented Oct 7, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@beardeddragon5
Copy link
Contributor Author

Ok, now it should be fixed. I didn't really care if it is me or my better looking me xD. What did we learned today: Never share an account with your split personality.

@wing328 wing328 added this to the 3.3.1 milestone Oct 10, 2018
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and the result is good. Later I'll file a PR with an additional test case.

@wing328 wing328 merged commit 6acf45a into OpenAPITools:master Oct 10, 2018
@wing328 wing328 changed the title x-www-form-urlencoded-body-fix [Go] Fix for form parameters (x-www-form-urlencoded) Oct 10, 2018
@wing328
Copy link
Member

wing328 commented Oct 16, 2018

@beardeddragon5 thanks again for the fix, which has been included in the v3.3.1 release: https://twitter.com/oas_generator/status/1052020299821080577

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* [go] x-www-form-urlencoded-body-fix

* [go] run scripts in bin and bin/security
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants