Re-enabling typescript Node test with Node v8 #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Explicitly adding node.js 8 type definitions before ClientResponse interface was removed due to deprecation.
|
Should be okay now, I think |
|
@osharav yup looks good to me. |
wing328
changed the title
|
@osharav thanks again for the fix and we just released v3.3.1: https://twitter.com/oas_generator/status/1052020299821080577 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
Explicitly adding node.js 8 type definitions before ClientResponse interface was removed due to deprecation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly adding node.js 8 type definitions before ClientResponse interface was removed due to deprecation.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
As requested in: #1138 trying to fix issue with typescript compiler for typescript-node test.
This seems to be a result of a change in the https://github.com/DefinitelyTyped/DefinitelyTyped repo.
They have deprecated the ClientResponse interface in node 10.
To resolve (at least until the generator uses the new IncomingMessage interface), I've specifically used the type definitions for node 8 in the relevant package.mustache file.
I've ran the sample, installed node_modules and then confirmed that I can run tsc and see the compiled JavaScript.
Regards,
Omer.