Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inline model schema's name is wrong #14687

Merged

Conversation

davidediak
Copy link
Contributor

@davidediak davidediak commented Feb 14, 2023

Fixes #14688

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Feb 16, 2023

thanks for the fix, can you please share a minimal spec to reproduce the issue?

i'm sure you're aware that the inline schema mapping can be customized: https://github.com/OpenAPITools/openapi-generator/blob/master/docs/customization.md#inline-schema-naming

@wing328
Copy link
Member

wing328 commented Feb 16, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@davidediak davidediak force-pushed the bug-inline-model-schemas-name-is-wrong branch from de033be to fcf97ae Compare February 16, 2023 07:08
@davidediak
Copy link
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Sorry about that, should be ok now.

@davidediak
Copy link
Contributor Author

@wing328 I've added spec + how to reproduce in the related linked issue.
Let me know if something is still missing.

@wing328 wing328 added Issue: Bug Inline Schema Handling Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf labels Feb 17, 2023
@wing328
Copy link
Member

wing328 commented Feb 17, 2023

tested locally to confirm the fix:

--- a/.openapi-generator/FILES
+++ b/.openapi-generator/FILES
@@ -1,12 +1,11 @@
 .github/workflows/maven.yml
 .gitignore
-.openapi-generator-ignore
 .travis.yml
 README.md
 api/openapi.yaml
 build.gradle
 build.sbt
-docs/ApiV1CustomerIdGetRequest.md
+docs/ApiV1CustomerIdPatchRequest.md
 docs/CustomerResponse.md
 docs/DefaultApi.md
 git_push.sh
@@ -37,8 +36,6 @@ src/main/java/org/openapitools/client/auth/Authentication.java
 src/main/java/org/openapitools/client/auth/HttpBasicAuth.java
 src/main/java/org/openapitools/client/auth/HttpBearerAuth.java
 src/main/java/org/openapitools/client/model/AbstractOpenApiSchema.java
-src/main/java/org/openapitools/client/model/ApiV1CustomerIdGetRequest.java
+src/main/java/org/openapitools/client/model/ApiV1CustomerIdPatchRequest.java
 src/main/java/org/openapitools/client/model/CustomerResponse.java
-src/test/java/org/openapitools/client/api/DefaultApiTest.java
-src/test/java/org/openapitools/client/model/ApiV1CustomerIdGetRequestTest.java
-src/test/java/org/openapitools/client/model/CustomerResponseTest.java
+src/test/java/org/openapitools/client/model/ApiV1CustomerIdPatchRequestTest.java

@wing328 wing328 added this to the 6.4.0 milestone Feb 17, 2023
@wing328 wing328 merged commit 09ff222 into OpenAPITools:master Feb 17, 2023
@wing328
Copy link
Member

wing328 commented Feb 17, 2023

@davidediak thanks for the fix, which has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Inline Schema Handling Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf Issue: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Inline model schema's name is wrong
2 participants