-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Inline model schema's name is wrong #14687
fix: Inline model schema's name is wrong #14687
Conversation
thanks for the fix, can you please share a minimal spec to reproduce the issue? i'm sure you're aware that the inline schema mapping can be customized: https://github.com/OpenAPITools/openapi-generator/blob/master/docs/customization.md#inline-schema-naming |
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
de033be
to
fcf97ae
Compare
Sorry about that, should be ok now. |
@wing328 I've added spec + how to reproduce in the related linked issue. |
tested locally to confirm the fix: --- a/.openapi-generator/FILES
+++ b/.openapi-generator/FILES
@@ -1,12 +1,11 @@
.github/workflows/maven.yml
.gitignore
-.openapi-generator-ignore
.travis.yml
README.md
api/openapi.yaml
build.gradle
build.sbt
-docs/ApiV1CustomerIdGetRequest.md
+docs/ApiV1CustomerIdPatchRequest.md
docs/CustomerResponse.md
docs/DefaultApi.md
git_push.sh
@@ -37,8 +36,6 @@ src/main/java/org/openapitools/client/auth/Authentication.java
src/main/java/org/openapitools/client/auth/HttpBasicAuth.java
src/main/java/org/openapitools/client/auth/HttpBearerAuth.java
src/main/java/org/openapitools/client/model/AbstractOpenApiSchema.java
-src/main/java/org/openapitools/client/model/ApiV1CustomerIdGetRequest.java
+src/main/java/org/openapitools/client/model/ApiV1CustomerIdPatchRequest.java
src/main/java/org/openapitools/client/model/CustomerResponse.java
-src/test/java/org/openapitools/client/api/DefaultApiTest.java
-src/test/java/org/openapitools/client/model/ApiV1CustomerIdGetRequestTest.java
-src/test/java/org/openapitools/client/model/CustomerResponseTest.java
+src/test/java/org/openapitools/client/model/ApiV1CustomerIdPatchRequestTest.java |
@davidediak thanks for the fix, which has been merged. |
Fixes #14688
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)