-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] [Gradle Plugin] Allow templates from classpath #14909
[Enhancement] [Gradle Plugin] Allow templates from classpath #14909
Conversation
14894e0
to
0ee81bd
Compare
This relates to this issue: #14909 |
@jimschubert - would dearly love to see this merged into the project. |
@dimber-cais thanks for the PR. Can you please add a test or two? |
@wing328 - I've not been able to successfully add a test for this. It's tricky as it relies on additional JARs being added into the plugin's classpath in order to leverage this feature. I have however, created a simple example project which demonstrates this behavior, which hopefully provides confidence that this change works as expected. The project can be found here: https://github.com/dimber-cais/openapi-generator-custom-classpath-templates-example |
@wing328 - Are you still planning on including this into the 7.0.0 release? |
I am interested in this as well, since this is a missing capability needed for our development. It looks like it is still tagged to the 7.0.0 milestone, but there has been no progress on the PR. |
@wing328 Any updates on that PR? Would be great to have it in 7.1.0 🚀 |
Bump for this - the PR is very minimal and is only setting an existing config: would be great to have this in |
Any update on this PR? It would be a very welcome addition and has been pushed back for over a year. Does it still depend on succesful tests being added @wing328 ? |
ideally we need a test or 2 but looks like it's not simple to add and no one has time to dig into it. i'll merge it and please help test the snapshot version (published later as part of CI workflow) to ensure everything works as expected. |
I will do that as soon as it is available (and I am also). I can't find the workflow to see when this is. I will check tomorrow. Also noticed I was still on 7.3.0 so had to resolve some issues upgrading to 7.6.0. |
@wing328 Perhaps a silly question, but I can't find how I can use the SNAPSHOT version in my project to test this, apart from building it locally. Is there a way to get the snapshot plugin from the web? |
Enhance the Gradle plugin to support loading templates from the classpath. This is already a feature of the Maven plugin, and this PR uses the same approach.