[PHP] Bump minimum required version to PHP7.1 #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackintosh
added
Breaking change (without fallback)
Client: PHP
WIP
ackintosh
force-pushed
the
bump-to-php71
branch
from
da74229
to
a86b662
Compare
bin/openapi3/php-petstore.sh
The tests in "samples/openapi3" has passedThe result of tests phpunit "test" folder (auto-generated tests)Note: All tests are regarded as risky tests as the generated tests have no assertiions. vendor/bin/phpunit test/
PHPUnit 7.4.4 by Sebastian Bergmann and contributors.
RRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRR 63 / 201 ( 31%)
RRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRR 126 / 201 ( 62%)
RRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRR 189 / 201 ( 94%)
RRRRRRRRRRRR 201 / 201 (100%)
Time: 118 ms, Memory: 8.00MB
There were 201 risky tests:
...
...
OK, but incomplete, skipped, or risky tests!
Tests: 201, Assertions: 0, Risky: 201.The result of phpunit under "tests" folderAll green 💚 $ cd samples/openapi3/client/petstore/php/OpenAPIClient-php
$ vendor/bin/phpunit tests/
PHPUnit 7.4.4 by Sebastian Bergmann and contributors.
................................................................. 65 / 66 ( 98%)
. 66 / 66 (100%)
Time: 13.51 seconds, Memory: 28.00MB
OK (66 tests, 4705 assertions) |
ackintosh
force-pushed
the
bump-to-php71
branch
2 times, most recently
from
f141dbb
to
2724fc5
Compare
ackintosh
force-pushed
the
bump-to-php71
branch
from
2724fc5
to
9a1425d
Compare
bin/security/php-petstore.sh
|
@jebentier (2017/07) @dkarlovi (2017/07) @mandrean (2017/08) @jfastnacht (2017/09) @ackintosh (2017/09) @ybelenko (2018/07) |
wing328
approved these changes
Nov 24, 2018
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Bump minimum required version to PHP7.1 ref: http://php.net/supported-versions.php * Bump phpunit * Update [api|model]_test.mustache * Update samples bin/openapi3/php-petstore.sh * Update namespace of PHPUnit ("tests" folder) * `setExpectedException` is deleted in PHPUnit 7.4 * Update namespace of "Assert" class * The attribute 'name' is required * Add anotation to exclude the test from risky testcheck * Update samples (samples/client/petstore/php) * Apply updates to "test" in openapi2 folder (samples/client/petstore/php) OpenAPITools@b3495ec OpenAPITools@15e00ae OpenAPITools@2fc6917 OpenAPITools@0d016c0 * Install php7.1 * Switch to php7 * Update samples (security) bin/security/php-petstore.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
Related issue: PHP 5.x reaches the end of life by the end of 2018 · Issue #1246 · OpenAPITools/openapi-generator
What I do in this PR :