Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop default value when unnecessary. #15368

Merged
merged 4 commits into from
May 2, 2023

Conversation

noordawod
Copy link
Contributor

The generated Dart2 code included default values when unnecessary, this pr removes them.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

@noordawod
Copy link
Contributor Author

The failed tests are unrelated to the changes in the Dart2 template, most are Python-related but one is scala-akka-related…

@noordawod noordawod force-pushed the feature/drop-default-value branch from a50bfea to 501c9b7 Compare May 1, 2023 09:16
@noordawod
Copy link
Contributor Author

Wondering when will this pr get merged, @agilob?

@ahmednfwela
Copy link
Contributor

@wing328

@wing328 wing328 added this to the 6.6.0 milestone May 2, 2023
@wing328 wing328 merged commit fefbfd6 into OpenAPITools:master May 2, 2023
@noordawod noordawod deleted the feature/drop-default-value branch May 2, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants