Introduced GeneratorProperties as a thread-safe clone of System Properties #1598
Conversation
| @@ -0,0 +1,58 @@ | |||
| /* | |||
| * Copyright 2018 OpenAPI-Generator Contributors (https://openapi-generator.tech) | |||
| * Copyright 2018 SmartBear Software | |||
There was a problem hiding this comment.
For new files, there's no need to include line 3. Please refer to https://opensource.stackexchange.com/questions/7300/copyright-notice-in-the-file-header-apache-v2-license/7301#7301 for more information.
There was a problem hiding this comment.
@gndrm after you remove line 3, we'll be happy to merge your contributions to the master.
Have a nice weekend.
There was a problem hiding this comment.
done, sorry for the late reply. was very short on time the last weeks.
|
@gndrm thanks for the PR, which has been merged into master. |
|
@gndrm I got the following warning when running Did you get similar warning when running |
|
@wing328 i cannot reproduce your warning. i checked out the master today on a fresh system and ran |
|
@gndrm 👌 Thanks again for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529. Happy New Year and looking forward to more collaboration and contributions in 2019! |
…rties (OpenAPITools#1598) * Introduced GeneratorProperties as a thread-safe clone of System Properties * Removed unnecessary SmartBear copyright
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
see Issue #1597.
Implemented GeneratorProperties with a thread-local clone of SystemProperties to be used while Running generator-plugins.