Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API Key Authentication code for go when cookie is used. #1601

Merged

Conversation

dmascialino
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This fix the issue #1600 .

This allow us to compile the client, and we are using this way to maintain the cookie:

jar, _ := cookiejar.New(&cookiejar.Options{PublicSuffixList: publicsuffix.List})
cfg.HTTPClient = &http.Client{nil, nil, jar, 0}
client := openapi.NewAPIClient(cfg)

We get authenticated sending an apiToken to the autentication endpoint.

@dmascialino
Copy link
Contributor Author

Go Technincal committee: @antihax @bvwells @grokify @kemokemo

@wing328
Copy link
Member

wing328 commented Dec 3, 2018

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@dmascialino dmascialino force-pushed the fix_go_client_when_cookie_is_used branch from 6320f26 to 267fef8 Compare December 3, 2018 16:34
@dmascialino
Copy link
Contributor Author

Thank you @wing328 for your help, I already fixed the commit author.

@antihax
Copy link
Contributor

antihax commented Dec 3, 2018

Looks good for single key use case.
Would there also be a way to pass this by request (through context) for multiple key cases?

@dmascialino
Copy link
Contributor Author

@antihax

Would there also be a way to pass this by request (through context) for multiple key cases?

Not sure how to deal with it, do you have an example allowing multiple keys? (maybe in other client)

@dmascialino
Copy link
Contributor Author

Hi @antihax @bvwells @grokify @kemokemo, what sould I do to get this PR merged?
Thanks!

@dmascialino
Copy link
Contributor Author

Hi, what is needed to move this PR forward?
thanks

@wing328 wing328 added this to the 4.0.0 milestone Feb 18, 2019
@wing328
Copy link
Member

wing328 commented Feb 18, 2019

@dmascialino sorry for the delay. Just merged it into master.

@wing328 wing328 merged commit cd1885d into OpenAPITools:master Feb 18, 2019
@dmascialino
Copy link
Contributor Author

great! thank you William

jimschubert added a commit that referenced this pull request Feb 23, 2019
* master: (40 commits)
  [Python] remove default value from being fallback to example (#2213)
  Add petstore integration tests to Ruby OAS3 client (#2211)
  Gradle - make GenerateTask properties optional (#2185)
  skip bats installation (#2198)
  Something in the dependencies changed. This switch is no longer needed. (#1850)
  Use oauth token for basic bearer auth in Rust. (#2161)
  Fix missing nullable (#2189)
  Enable error handling in Java WebClient library, fixes #1243 (#1244)
  [core] fix referenced enum case (#2175)
  rest-template: allow array parameters in path using collectionFormat (#2177)
  update go petstore samples
  Fix string types for cpprestsdk client generator (#1676)
  update kotline samples
  Remove API Key Authentication code for go when cookie is used. (#1601)
  changed the package install instructions to install the .tgz package … (#1989)
  okhttp-gson: allow array parameters in path using collectionFormat (#2137)
  [Ruby] Fix regualr expression in error message (#2069) (#2139)
  [kotlin][client] bytearray conversion (#2166)
  [rust-server] Added client documentation to rust-server (#2159)
  [Java] Getter/Setter naming convention not followed in generated models (#2095)
  ...
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants