Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elm] Enable setting Http request trackers #1609

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

eriktim
Copy link
Contributor

@eriktim eriktim commented Dec 4, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Allow setting a tracker Maybe String for your Elm Http Requests, instead of the hardcoded Nothing.

Can you have a look, @wing328 ?

@eriktim eriktim added this to the 4.0.0 milestone Dec 4, 2018
@wing328 wing328 changed the base branch from 4.0.x to master December 5, 2018 07:16
@wing328
Copy link
Member

wing328 commented Dec 5, 2018

UPDATE: changed the target branch to master as 4.0.x branch has been merged into master in preparation for the upcoming major release.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit c0634ac into OpenAPITools:master Dec 6, 2018
@eriktim
Copy link
Contributor Author

eriktim commented Dec 6, 2018

Thanks!

@eriktim eriktim deleted the elm-tracker branch December 6, 2018 15:56
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants