Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include mavenCentral in java build.gradle #1653

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

jimschubert
Copy link
Member

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

the android dep is currently missing from jcenter. This adds
mavenCentral as an additional repository to the default java generator's
build.gradle.

This addresses an issue my team at work has on a PR verification job we run on each commit. We're seeing this problem:

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'openapi-java-client'.
> Could not resolve all dependencies for configuration ':classpath'.
   > Could not find any matches for com.android.tools.build:gradle:2.3.+ as no versions of com.android.tools.build:gradle are available.
     Searched in the following locations:
         https://jcenter.bintray.com/com/android/tools/build/gradle/maven-metadata.xml
         https://jcenter.bintray.com/com/android/tools/build/gradle/
     Required by:
         :openapi-java-client:unspecified

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 3.901 secs

/cc technical committee:
@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger

the android dep is currently missing from jcenter. This adds
mavenCentral as an additional repository to the default java generator's
build.gradle.
@wing328 wing328 added this to the 4.0.0 milestone Dec 14, 2018
@wing328 wing328 merged commit 1f95b54 into OpenAPITools:master Dec 14, 2018
@wing328
Copy link
Member

wing328 commented Dec 14, 2018

@jimschubert thanks for the PR.

I'll submit a separate PR to update other build.gradle.mustache (e.g. Android, Java Retrofit2, etc) and update the samples.

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
the android dep is currently missing from jcenter. This adds
mavenCentral as an additional repository to the default java generator's
build.gradle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants