Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dart] Make dependency on intl package less strict #17862

Merged
merged 1 commit into from
Feb 15, 2024
Merged

[Dart] Make dependency on intl package less strict #17862

merged 1 commit into from
Feb 15, 2024

Conversation

wiesnery
Copy link
Contributor

The hard reuirement of intl: '^0.18.0' limits current and future update behavior.
It is recommended by the flutter team to depend on intl: any instead.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

@wiesnery
Copy link
Contributor Author

@ahmednfwela @sbu-WBT Thanks for the quick review cycle! Can you also merge the PR?

@ahmednfwela
Copy link
Contributor

@wing328

@wing328 wing328 added this to the 7.4.0 milestone Feb 15, 2024
@wing328 wing328 merged commit 41bb5cd into OpenAPITools:master Feb 15, 2024
15 checks passed
@wiesnery wiesnery deleted the patch-1 branch February 15, 2024 06:29
kota65535 pushed a commit to kota65535/openapi-generator that referenced this pull request Feb 23, 2024
@aviadkam
Copy link

@wiesnery
What do you say about doing the same for http package? I am having trouble with other packages that require a higher minimal version of http package.

@wiesnery
Copy link
Contributor Author

wiesnery commented Jun 17, 2024

@aviadkam
current version of http is: 1.2.1 why are we that far behind?
Starting with version 1.0.0 dart 3 is required - not sure if this would be too much of a breaking change.

As there don't seem to be any documented API changes we could go from '>=0.13.0 <0.14.0' to: >=0.13.0 <2.0.0
If we do that we should proceed with the collections package as well from '^1.17.0' to '>=1.17.0 <2.0.0 as this dependency blocks upgrading often. -> Maybe we could event eliminate the dependency as these are only convenience functions, right?
What do you think?
Maybe we should open up a new issue for each of them.

@aviadkam
Copy link

For http >=0.13.0 <2.0.0 is a good idea
for collection, I think we can also do >=1.17. <2.0.0. It will take time to make it to 2.0.0. The functionality is fundamental, and I hope it will not break.

Another thought - If intl is any, maybe we can put all as any? Or just restrict the minimal version?
The generator must be as open as possible because it builds the SDK.

@wiesnery
Copy link
Contributor Author

As far as I understood the intl dependency, it is required to have it because of some provider it brings but there is no real API access. This however is different to http and collection so I would not go for any in this case. Open ok but we don't have any compile-time check if the project really works with other dependency versions. So I would recommend using the above specified dependency range.
Do you want to file the PR? @aviadkam?

@aviadkam
Copy link

I agree. If you could do the PR, I would appreciate it. It will be my first PR on the project, and it always takes more time for a freshman. If you are not available, then I will do it. Thank you

@wiesnery
Copy link
Contributor Author

you can finde the PR for http, collection and meta here #18952

@aviadkam
Copy link

you can finde the PR for http, collection and meta here #18952

Thank you very very much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants