[R][Client] allow to initialize enum classes without parameters #18183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)modelEnum.mustache
currently produces classes that do not allow initialization asThe above produces an error due to
stopifnot(length(val) == 1L)
. The problem is that if this enum class is a parameter in another class, within thefromJSON
function of this class it will sayand in turn try to initialize the enum class as given above. I re-wrote the initialization in
modelEnum.mustache
to behave as before if a wrong enum value is given, but allow initializing asMyEnumClass$new()
by using a dummy enumDUMMY_ENUM
and warning the user about it. This way the user is warned when using the class itself incorreclty, but can (in most cases) ignore the warning if the enum is instantly corrected like in the latter code example.TL;DR having an enum class as a class parameter currently does not work in any case, and this PR allows it to work (while expressing warnings to the user)
Technical committee @Ramanth @saigiridhar21