Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Use Marcel to detect content-type in form-data file upload using faraday #18243

Conversation

ykitamura-mdsol
Copy link
Contributor

The fix made in #17853 introduced requiring a native gem, ruby-filemagic.
Installing FileMagic library just to detect content-type is not a pleasant approach and I think marcel is the way we should go in 2024.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 @dvacca-onfido

@ykitamura-mdsol ykitamura-mdsol force-pushed the ruby-faraday-use-marcel-to-detect-content-type branch from b5687ce to 52115fd Compare March 27, 2024 16:19
@dvacca-onfido
Copy link
Contributor

LGTM. Thanks for improving that, much better like this. 👍

@wing328 wing328 added this to the 7.5.0 milestone Mar 29, 2024
@wing328 wing328 merged commit 34ebc1c into OpenAPITools:master Mar 29, 2024
17 checks passed
@ykitamura-mdsol ykitamura-mdsol deleted the ruby-faraday-use-marcel-to-detect-content-type branch March 29, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants