Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift] Added solution for deprecated "UTTypeCopyPreferredTagWithClass" #18330

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

egesucu
Copy link
Contributor

@egesucu egesucu commented Apr 8, 2024

UTTypeCopyPreferredTagWithClass is deprecated with iOS 15, so apps targeting iOS 15+ were getting this warning on any auto-generated code. This solution will solve that warning and works both iOS 15 and below.

Related Warnings

  • URLSessionImplementations.swift:563:22 'UTTypeCreatePreferredIdentifierForTag' was deprecated in iOS 15.0: Use the UTType class instead.
  • URLSessionImplementations.swift:563:60 'kUTTagClassFilenameExtension' was deprecated in iOS 15.0: Use UTTagClassFilenameExtension instead.
  • URLSessionImplementations.swift:564:32 'UTTypeCopyPreferredTagWithClass' was deprecated in iOS 15.0: Use the UTType class instead.
  • URLSessionImplementations.swift:564:69 'kUTTagClassMIMEType' was deprecated in iOS 15.0: Use UTTagClassMIMEType instead.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

UTTypeCopyPreferredTagWithClass is deprecated with iOS 15, so apps targeting iOS 15+ were getting this warning on any auto-generated code. This solution will solve that warning and works both iOS 15 and below.
@egesucu
Copy link
Contributor Author

egesucu commented Apr 8, 2024

@dydus0x14 You can check out the fix code and let me know if there needs to be an improvement.

@egesucu egesucu changed the title Added solution for deprecated "UTTypeCopyPreferredTagWithClass" [swift] Added solution for deprecated "UTTypeCopyPreferredTagWithClass" Apr 8, 2024
@wing328
Copy link
Member

wing328 commented Apr 9, 2024

cc
@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)

@4brunu
Copy link
Contributor

4brunu commented Apr 9, 2024

Looks good to me 👍

@4brunu 4brunu merged commit 1a06e3e into OpenAPITools:master Apr 9, 2024
32 of 33 checks passed
@wing328 wing328 added this to the 7.5.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants