[html2] Fix blank responses in html document #18356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14642
fix #3788
fix #11204
fix #1373
Removed {{#schema}} section tag, so that {{{jsonSchema}}} and the other mustache variables can be retrieved via
apiInfo.apis.operation.responses
I tested by using the html generated by
modules/openapi-generator/src/test/resources/3_1/petstore.yaml
.Before my fixing, responses were empty if $ref was used in yaml. It happened because {{{jsonSchema}}} was null in
apiInfo.apis.operation.responses.schema
, but exitsts inapiInfo.apis.operation.responses
. So the generated script was incomplete asvar schemaWrapper = ;
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)