[Go] fix allOf with multiple ref and discriminator #18390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltoshev
approved these changes
Apr 15, 2024
|
tested locally and the fix looks good. thanks for the fix |
wing328
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the "FinalItem" is a composite schema the parent is not added.
It seems this is done to handle the "additionalProperties".
My proposal is for this to work for "isMap" schemas and use the parentModel.name which for the items with additionalProperties would be null anyway.
@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5
To close #18385