Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Update ApiClient.mustache for retrofit2 + rxJava3 #19266

Conversation

PeregrineFalcon
Copy link
Contributor

@PeregrineFalcon PeregrineFalcon commented Jul 29, 2024

  • Support to use official square implementation of rxJava3 adapter instead of 3rd party in code gen for retrofit and RxJava3
  • Updates README to reflect that rxJava2 and rxJava3 are not actually deprecated

@martin-mfg for review since changes to the Java code gen

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…cial square implementation of rxJava3 adapter
@wing328
Copy link
Member

wing328 commented Jul 30, 2024

Updates README to reflect that rxJava2 and rxJava3 are not actually deprecated

we will decommission rxJava2 support as users should be using rxJava3 instead.

@wing328
Copy link
Member

wing328 commented Jul 30, 2024

thanks for the PR

looks good to me and will merge after all tests pass.

@wing328 wing328 added this to the 7.8.0 milestone Jul 30, 2024
@wing328 wing328 merged commit 753502c into OpenAPITools:master Jul 30, 2024
64 checks passed
@PeregrineFalcon
Copy link
Contributor Author

Updates README to reflect that rxJava2 and rxJava3 are not actually deprecated

we will decommission rxJava2 support as users should be using rxJava3 instead.

Yeah I figured, that does make sense. I didn't want to make that change in this PR because it seemed drastic. Agreed rxJava3 should be the path going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants