[typescript] fix: deno: type exports for isolatedModules
#19484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscha
commented
Aug 29, 2024
| @@ -16,7 +16,7 @@ export { Middleware } from './middleware{{importFileExtension}}'; | |||
| export{{#platforms}}{{#deno}} type{{/deno}}{{/platforms}} { PromiseMiddleware as Middleware } from './middleware{{importFileExtension}}'; | |||
| {{/useRxJS}} | |||
| {{#useObjectParameters}} | |||
| export { {{#apiInfo}}{{#apis}}{{#operations}}{{#operation}}{{classname}}{{operationIdCamelCase}}Request, {{/operation}}Object{{classname}} as {{classname}}{{^-last}}, {{/-last}} {{/operations}}{{/apis}}{{/apiInfo}}} from './types/ObjectParamAPI{{importFileExtension}}'; | |||
| export { {{#apiInfo}}{{#apis}}{{#operations}}{{#operation}}{{#platforms}}{{#deno}}type {{/deno}}{{/platforms}}{{classname}}{{operationIdCamelCase}}Request, {{/operation}}Object{{classname}} as {{classname}}{{^-last}}, {{/-last}} {{/operations}}{{/apis}}{{/apiInfo}}} from './types/ObjectParamAPI{{importFileExtension}}'; | |||
There was a problem hiding this comment.
this is the meaningful change of this PR.
It makes sure that any re-exported request object is exported with the type keyword, e.g.
export { AuthApiXRequest, ObjectAuthApi as AuthApi } from './types/ObjectParamAPI.ts';becomes
export { type AuthApiXRequest, ObjectAuthApi as AuthApi } from './types/ObjectParamAPI.ts';e.g. meaning
export {
- AuthApiXRequest,
+ type AuthApiXRequest,
ObjectAuthApi as AuthApi
} from './types/ObjectParamAPI.ts';An alternative, possibly more readable implementation would be to split the type exports from the classes, e.g.:
export { ObjectAuthApi as AuthApi, ObjectBlaApi as BlaApi } from './types/ObjectParamAPI.ts';
export type { AuthApiXRequest, BlaApiXRequest } from './types/ObjectParamAPI.ts';
joscha
commented
Aug 29, 2024
| export { RequiredError } from "./apis/baseapi.ts"; | ||
|
|
||
| export type { PromiseMiddleware as Middleware } from './middleware.ts'; | ||
| export { type PetApiAddPetRequest, type PetApiDeletePetRequest, type PetApiFindPetsByStatusRequest, type PetApiFindPetsByTagsRequest, type PetApiGetPetByIdRequest, type PetApiUpdatePetRequest, type PetApiUpdatePetWithFormRequest, type PetApiUploadFileRequest, ObjectPetApi as PetApi, type StoreApiDeleteOrderRequest, type StoreApiGetInventoryRequest, type StoreApiGetOrderByIdRequest, type StoreApiPlaceOrderRequest, ObjectStoreApi as StoreApi, type UserApiCreateUserRequest, type UserApiCreateUsersWithArrayInputRequest, type UserApiCreateUsersWithListInputRequest, type UserApiDeleteUserRequest, type UserApiGetUserByNameRequest, type UserApiLoginUserRequest, type UserApiLogoutUserRequest, type UserApiUpdateUserRequest, ObjectUserApi as UserApi } from './types/ObjectParamAPI.ts'; |
There was a problem hiding this comment.
this is the meaningful change in the generated fixture. Please let me know if you prefer to introduce some newlines between the different imports/exports, which would make this a lot more readable, but also would increase the diff of this PR, because it would affect other samples as well.
macjohnny
approved these changes
Aug 29, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating code with
typescriptthat contains request objects for thedenoplatform the following type error is produced in the generated code:Deno has
isolatedModulesenabled by default and it can not be disabled (see denoland/deno#12599 (comment)).Thus imports that are reexported need to have the
typekeyword.A similar change has been made in #826.
PR checklist
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)