Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin-spring] fix springdoc dependencies #19579

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

un1024
Copy link
Contributor

@un1024 un1024 commented Sep 14, 2024

When I generate with "useSwaggerUI": "false", It generates bellow dependency.

implementation("org.springdoc:springdoc-openapi-webmvc-core:2.2.0-M5")

But it is incorrect dependency(this version is not exists.), so I'm getting the following error.

Could not find org.springdoc:springdoc-openapi-webmvc-core:2.2.0-M5.

I fixed it to use version springdoc v2.
ref: https://springdoc.org/#migrating-from-springdoc-v1

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@un1024
Copy link
Contributor Author

un1024 commented Sep 14, 2024

Java Spring Technical Committee

@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

thx.

@wing328
Copy link
Member

wing328 commented Sep 19, 2024

lgtm. thanks for the PR

fyi
@dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

@wing328 wing328 merged commit 410113f into OpenAPITools:master Sep 19, 2024
15 checks passed
@wing328 wing328 added this to the 7.9.0 milestone Sep 19, 2024
@wing328
Copy link
Member

wing328 commented Sep 19, 2024

UPDATE: filed and merged #19620 to update both api & ui to verison 2.6.0

please pull the latest master to give it another try

@un1024 un1024 deleted the fix-kotlin-dependncy-springdoc branch September 21, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants