Typescript+Axios: multipart/form-data correctly handled #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvniekerk
changed the title
macjohnny
reviewed
Jan 28, 2019
| @@ -24,7 +24,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@types/node": "^8.0.9", | |||
| "typescript": "^2.4" | |||
| "typescript": "^3.2" | |||
There was a problem hiding this comment.
which feature requires typescript 3.2? I would widen the restriction as much as possible
There was a problem hiding this comment.
Reverted at 9818ee8 -
Thought the spread operators was a later language feature
| : configuration.accessToken; | ||
| const localVarAccessTokenValue = typeof configuration.accessToken === 'function' | ||
| ? configuration.accessToken("petstore_auth", ["write:pets", "read:pets"]) | ||
| : configuration.accessToken; | ||
| localVarHeaderParameter["Authorization"] = "Bearer " + localVarAccessTokenValue; | ||
| } | ||
|
|
||
| if (tags) { | ||
| localVarQueryParameter['tags'] = tags.join(COLLECTION_FORMATS["csv"]); |
There was a problem hiding this comment.
should be adapted too, for consistency
There was a problem hiding this comment.
Addressed in 3ba25dc
| public Map<String, Object> postProcessOperations(Map<String, Object> objs) { | ||
| objs = super.postProcessOperations(objs); | ||
| Map<String, Object> vals = (Map<String, Object>)objs.get("operations"); | ||
| List<CodegenOperation> operations = (List<CodegenOperation>)vals.get("operation"); |
There was a problem hiding this comment.
Addressed in 3ba25dc
|
On an unrelated note - seems like the Shippable pipeline is broken due to debian packages being missing. |
This was referenced Jan 28, 2019
|
@mvniekerk the build failed with the following errors: Please take a look and let us know if you need help fixing the issue. |
|
Update: Pushed 061cea5 to fix the compilation error. Let's see how it goes. |
|
All CI tests passed 👍 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…#2002) * Typescript 3.2 * Typescript spread operator * Add vendor extension to the operation * Remove url.URLSearchParams * Generate form data in API * Make axios scripts executable * Reran generator * Generate sample code * Revert to 2.4 Typescript * COLLECTION_FORMAT.{{collectionFormat}} everywhere for consistency * Consistency on the CollectionFormats, comment on the vendor extension * fix compilation error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)
Description of the PR
When doing a multipart/formdata request, the current state is that it changes the content type to ''application/x-www-form-urlencoded" (violating the contract) and then does a toString() on the request data.
What this PR does is to use FormData as the data, it appends (instead of doing a .set()) and then omits the toString() when the content-type is multipart/form-data