Add "servers" support to the operation, path in PHP API client #2072
Conversation
| @@ -54,19 +54,47 @@ use {{invokerPackage}}\ObjectSerializer; | |||
| */ | |||
| protected $headerSelector; | |||
|
|
|||
| /** | |||
| * @var Host index | |||
There was a problem hiding this comment.
A 1st keyword of @var identifies the type of the property. so I think it would be @var int Host index .
There was a problem hiding this comment.
👍 I'll update it in the next push
| */ | ||
| public function __construct( | ||
| ClientInterface $client = null, | ||
| Configuration $config = null, | ||
| HeaderSelector $selector = null | ||
| HeaderSelector $selector = null, | ||
| $host_index = 0 |
There was a problem hiding this comment.
How about the $host_index generates only if servers exists in pathItems?
I just wondering that the $host_index is defined but unused. 👀
There was a problem hiding this comment.
Yes, very good suggestion. My intention is to make the constructor consistent across different API classes.
What about updating the doc string to explain it cleary that it's optional and only needed when the endpoint has multiple servers/hosts defined?
There was a problem hiding this comment.
Pushed some enhancements based on your feedback.
…PITools#2072) * add servers support to path, operation in php client * remove servers from spec * update based on feedback
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
An example of the change can be found in 64bf0d4#diff-15582b49a62d7a5ecac56414cfe6407fR332
cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09), @ybelenko (2018/07), @renepardon (2018/12)