Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aspnetcore] migrate the docker image for the aspnetcore generator #2281

Merged
merged 3 commits into from
Mar 3, 2019
Merged

Conversation

kemokemo
Copy link
Contributor

@kemokemo kemokemo commented Mar 2, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fix the issue #2278 and README.mustache for docker run.

@mandrean (2017/08), @jimschubert (2017/09)
Would you please review this PR?
Thank you so much! 😃

@jimschubert
Copy link
Member

Tested that this builds and runs with options for aspnetcore 2.0 and 2.1.

@jimschubert jimschubert merged commit 8c88f46 into OpenAPITools:master Mar 3, 2019
@kemokemo
Copy link
Contributor Author

kemokemo commented Mar 3, 2019

@jimschubert
Thank you for your testing and merging! 😄

@kemokemo kemokemo deleted the fix_2278 branch March 3, 2019 00:19
@wing328 wing328 added this to the 4.0.0 milestone Mar 3, 2019
@wing328 wing328 changed the title Fix 2278: migrate the docker image for the aspnetcore generator [aspnetcore] migrate the docker image for the aspnetcore generator Mar 3, 2019
jimschubert added a commit that referenced this pull request Mar 3, 2019
* master:
  Fix 2278: migrate the docker image for the aspnetcore generator (#2281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants