[Elixir] Deserialize responses based on status code #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode to arbitrary struct
…ilder.ex.mustache Co-Authored-By: yknx4 <[email protected]>
…ilder.ex.mustache Co-Authored-By: yknx4 <[email protected]>
|
Thank you very much for keeping the work on this 👍 |
|
@mrmstn 👌 |
|
@mrmstn when you've time, I wonder if you can help resolve the merge conflicts. |
|
@wing328 this should do the trick, the diff looks good to me now, let's see what the CI says |
|
Just merged the PR into master. Thanks for the contribution from @mrmstn |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
First of all, sorry if I might made some chaos. I branched this PR from the great work of @yknx4. I'm hoping the change history will look a little bit better after PR #2326 was merged.
With this PR the generated elixir client will be able deserialize a response based on the given statuscodes including the ability to match on a default response in case none of the give codes matches (https://swagger.io/docs/specification/describing-responses/)
This PR stops descriptions and doc parts from beeing escaped by mustache and will pin poison to
~> 3.0.0since poison4.0.0doesn't seems to work right now (I haven't investigated anything)based on #2326
closes #2334