[Java][okhttp-gson] Fix incorrect use of OkHttp interceptors #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoldenGnu
added a commit
to GoldenGnu/eve-esi
that referenced
this pull request
Mar 11, 2019
Generated with Burberius's openapi-generator OpenAPITools/openapi-generator#2356
burberius
pushed a commit
to burberius/eve-esi
that referenced
this pull request
Mar 11, 2019
* Generated with openapi-gnerator 3.3.4 Now include meta specs on generation * Fixed verify not adding auth * Update SsoApi.java * user-agent * Added CharacterInfo.getExpiresOnDate() * Updated openapi-generator Generated with Burberius's openapi-generator OpenAPITools/openapi-generator#2356
|
@burberius thanks for the PR. I notice that the additional tests added by @burberius are not yet included in this PR. I'll submit another PR to add the tests instead. I tested locally with the new test cases and all tests passed. Also thanks @ngaya-ll for the original work. |
wing328
changed the title
burberius
added a commit
to burberius/eve-esi
that referenced
this pull request
Mar 17, 2019
* Line ending changes Always use lf line ending for *.sed and *.sh files. Use default for everything else. * More line ending stuff * Final line ending change * Started on issue 78 * Better tests less failing * Better tests less failing (again) * More work on issue 78 * Issue 78 Better error handling * Issue 78 formatting * Less sync blocks * First commit switching to okhttp Status -Compiles and no test failures Known Issues: -soApi.revokeRefreshToken() and SsoApi.revokeAccessToken() does nothing. -SsoApi.getCharacterInfo() is just a wrapper for MetaApi.getVerify() * More work on okhttp Known issues: VerifyResponse.getExpiresOn() return a String should be Java8 Date format? * swagger codegen 2.3.1 * formatting * Bug Fix for OAuth Bug: Code allow you to match a refresh token with just a clientID * Ok http (#83) * Generated with openapi-gnerator 3.3.4 Now include meta specs on generation * Fixed verify not adding auth * Update SsoApi.java * user-agent * Added CharacterInfo.getExpiresOnDate() * Updated openapi-generator Generated with Burberius's openapi-generator OpenAPITools/openapi-generator#2356 * Added fixed openapi-generator. * Added new openapi generator and made script executable. * Update ApiClient.java Use the latest version of Burberius openapi-generator-cli * 2019-03-11 esi release 2019-03-11 esi release Promoted /v3/universe/names/ (now resolve faction ids) * ApiClientBuilder (#85) * ApiClientBuilder * little more work on the builder * Okhttp fixes (#89) * Fixed SsoAuth main * Updated CharacterInfo and SsoApi -Updated CharacterInfo with better method names + tests -SsoApi commen * Update README.md (#88) * ApiClientBuilder * little more work on the builder * Update README.md -Removed client secret (no longer used) -Updated link to MarketApiTest, ESI, and SSO * Formated pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Port of @ngaya-ll 's pull request from swagger to openapi.
See swagger-api/swagger-codegen#8053
I also added a test case to demonstrate the issue, which fails on the current master and passes on this branch.
On master the petshop generation is broken, so I couldn't produce the samples and run the tests!
Reviewers: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger
Thanks @ngaya-ll for the original work.