Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean example value in ruby client generator #2431

Merged
merged 2 commits into from
Mar 17, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Mar 17, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

A follow-up to #2386 (review)

cc @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@autopp
Copy link
Contributor

autopp commented Mar 17, 2019

@wing328 It looks like the CircleCI's failure can be fixed by running bin/security/ruby-client-petstore.sh and bin/openapi3/ruby-client-petstore.sh.

@wing328
Copy link
Member Author

wing328 commented Mar 17, 2019

@autopp thanks. I'll take care of that later today.

@autopp
Copy link
Contributor

autopp commented Mar 17, 2019

LGTM

@wing328 wing328 merged commit 22d21af into master Mar 17, 2019
@wing328 wing328 deleted the ruby_boolean_example branch March 17, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants