Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various updates in Akka Scala generator #2472

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Various updates in Akka Scala generator #2472

merged 3 commits into from
Mar 25, 2019

Conversation

joelvim
Copy link
Contributor

@joelvim joelvim commented Mar 21, 2019 •
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

  • Upgrade scala version to 2.12.8
  • Upgrade Akka version
  • Migrate from spray to Akka HTTP

Related to issue #2471

Update akka scala generator
266a834 
* Upgrade scala version to 2.12.8
* Upgrade Akka version
* Migrate from spray to Akka HTTP
@wing328
Copy link
Member

wing328 commented Mar 21, 2019

@joelvim thanks for the PR. Please run the scala-akka shell scripts (./bin/scala-akka*) or batch files (bin\windows\scala-akka*) to update the Petstore samples so that the CI can verify the change.

@wing328
Copy link
Member

wing328 commented Mar 22, 2019

CircleCI failed with the following errors:

[ERROR] Failed to execute goal on project scala-akka-petstore-client: Could not resolve dependencies for project org.openapitools:scala-akka-petstore-client:jar:1.0.0: Could not find artifact io.spray:spray-client:jar:1.3.4 in central (https://repo.maven.apache.org/maven2) -> [Help 1]

Please take a look when you've time.

@joelvim
Copy link
Contributor Author

joelvim commented Mar 22, 2019

Sorry I forgot to update pom.xml. It's done now.

@wing328 wing328 added this to the 4.0.0 milestone Mar 23, 2019
@wing328
Copy link
Member

wing328 commented Mar 23, 2019

cc @clasnake (2017/07), @jimschubert (2017/09), @shijinkui (2018/01), @ramzimaalej (2018/03)

@wing328
Copy link
Member

wing328 commented Mar 24, 2019

To close #2471

jimschubert
jimschubert approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@jimschubert jimschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with Akka, but from a Scala-only perspective I think this looks great.

@wing328 wing328 merged commit 5074f4d into OpenAPITools:master Mar 25, 2019
@wing328 wing328 changed the title Update akka scala generator Various update in Akka Scala generator Apr 4, 2019
@wing328 wing328 changed the title Various update in Akka Scala generator Various updates in Akka Scala generator Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimschubert jimschubert jimschubert approved these changes

Assignees
No one assigned
Labels
Breaking change (without fallback) Client: Scala Enhancement: Compatibility
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@joelvim @wing328 @jimschubert