Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Aspnetcore] add nullable support to parameters and properties #2529

Merged
merged 3 commits into from
Mar 30, 2019
Merged

[Aspnetcore] add nullable support to parameters and properties #2529

merged 3 commits into from
Mar 30, 2019

Conversation

drl-max
Copy link
Contributor

@drl-max drl-max commented Mar 27, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

I used the same solution I provided for nullable support for the csharp client, which can be seen in the pull request for issue #2528.

I think this can resolve the server-side request for issue #2269.

@jimschubert @mandrean - Please review and let me know if you have any feedback,

@wing328
Copy link
Member

wing328 commented Mar 29, 2019

@drl-max thanks for the PR, which looks good to me. Can you also apply another fix (#1819) to the aspnet core generator in this PR?

@wing328 wing328 added this to the 4.0.0 milestone Mar 29, 2019
@drl-max
Copy link
Contributor Author

drl-max commented Mar 29, 2019

@wing328 - I've updated the PR with the changes I thought were relevant. If I missed something, please let me know.

@wing328
Copy link
Member

wing328 commented Mar 30, 2019

The CircleCI issue has been addressed in the latest master.

@wing328 wing328 merged commit c4d982f into OpenAPITools:master Mar 30, 2019
@wing328 wing328 changed the title Aspnetcore nullable support [Aspnetcore] add nullable support to parameters and properties Mar 30, 2019
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request Apr 1, 2019
@jimschubert
Merge branch 'master' into ihsmarkitoss-feature/cleanup
9844afa 
* master: (48 commits)
  [Typescript AngularJS] fix Extra package prefix in api parameters operations (OpenAPITools#2522)
  OpenAPITools#1023 - [Scala] Use status family during response processing (OpenAPITools#1024)
  Generate setters for readonly properties in server code (OpenAPITools#1582)
  [JS] fix NPE for null string and improve Travis config file (OpenAPITools#2553)
  [elm] Update ISO 8601 library (fixes missing time zone designator) (OpenAPITools#2545)
  [csharp] update sample after OpenAPITools#2528 (OpenAPITools#2550)
  [JavaScript] fix index.js, ApiClient.js and test files generated to incorrect location (OpenAPITools#2511)
  Aspnetcore nullable support (OpenAPITools#2529)
  Csharp nullable support (OpenAPITools#2528)
  [C++] [Qt5] Add enum support for client and server (OpenAPITools#2339)
  Fixed typo in migration-from-swagger-codegen.md (OpenAPITools#2548)
  [TypeScript Client] fix install Aurelia + fix use deprecated function (OpenAPITools#2514)
  [KOTLIN] fix var name not correctly sanitized (OpenAPITools#2537)
  Update swagger-parser to '2.0.11-OpenAPITools.org-1' (OpenAPITools#2262)
  Add @karismann to Java and Kotlin technical committee (OpenAPITools#2542)
  Add GoDaddy to the list of companies using OpenAPI Generator (OpenAPITools#2541)
  [Kotlin SpringBoot Server] alternative: fix optional parameter not correctly declared in service (OpenAPITools#2539)
  improve indentation, update dependencies (OpenAPITools#2521)
  update kotlin spring samples
  [JAVA] Use specified data type in enum's fromValue instead of string (OpenAPITools#2347)
  ...
jimschubert added a commit that referenced this pull request Apr 2, 2019
@jimschubert
Merge branch 'master' into rienafairefr-templating
da803dc 
* master: (133 commits)
  #2503: fix out-of-memory issue with nested objects with arrays with maxItems set by limiting to max. 5 example items (#2536)
  remove emitDefaultValue option (#2559)
  fix EmitDefaultValue default vallue with false (#2558)
  Added API Key auth to rust-server (#2459)
  remove initialCaps and replace with camelize (#2546)
  Add packageName configuration to maven (#2429)
  [Typescript AngularJS] fix Extra package prefix in api parameters operations (#2522)
  #1023 - [Scala] Use status family during response processing (#1024)
  Generate setters for readonly properties in server code (#1582)
  [JS] fix NPE for null string and improve Travis config file (#2553)
  [elm] Update ISO 8601 library (fixes missing time zone designator) (#2545)
  [csharp] update sample after #2528 (#2550)
  [JavaScript] fix index.js, ApiClient.js and test files generated to incorrect location (#2511)
  Aspnetcore nullable support (#2529)
  Csharp nullable support (#2528)
  [C++] [Qt5] Add enum support for client and server (#2339)
  Fixed typo in migration-from-swagger-codegen.md (#2548)
  [TypeScript Client] fix install Aurelia + fix use deprecated function (#2514)
  [KOTLIN] fix var name not correctly sanitized (#2537)
  Update swagger-parser to '2.0.11-OpenAPITools.org-1' (#2262)
  ...
@jmini jmini mentioned this pull request Jul 9, 2019
Open
@yilinjuang yilinjuang mentioned this pull request Aug 2, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement: Feature Feature: OAS 3.0 spec support Server: C-Sharp
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@drl-max @wing328