Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #2551 #2552

Closed
wants to merge 1 commit into from
Closed

Fixed #2551 #2552

wants to merge 1 commit into from

Conversation

cvgaviao
Copy link

the json structure was causing the test failure

Signed-off-by: Cristiano Gavião [email protected]

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

the json structure was causing the test failure

Signed-off-by: Cristiano Gavião <[email protected]>
@karismann
Copy link
Contributor

karismann commented Apr 4, 2019

thanks for you PR but this problem has already been fixed on master with the swagger-parser update (#2262)
i think you can close this PR

@cvgaviao cvgaviao closed this Apr 4, 2019
@cvgaviao
Copy link
Author

cvgaviao commented Apr 4, 2019

@karismann, I closed it. But now occurred me that this doesn't seems to be a parser error. if you compare the same petstore.yaml and petstore.json they look different. or am I seeing too much ? :)

Btw, I tried to build with the snapshot version of swagger-parser.

@cvgaviao cvgaviao reopened this Apr 4, 2019
@karismann
Copy link
Contributor

you're right . the default is not properly defined on the yaml :
it should be defined on the array as if you execute a query "findByStatus" without status, it took the available pets by default.
i'm quite suprised that this mistake is also present on the swagger editor default petstore spec :
findpetbystatus

@cvgaviao
Copy link
Author

cvgaviao commented Apr 5, 2019

i'm quite suprised that this mistake is also present on the swagger editor default petstore spec :

yep, but what I inferred is that snapshot version of swagger-parser started to deal with this flaw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants