Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maven] remove validateSpec #2614

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Conversation

jimschubert
Copy link
Member

@jimschubert jimschubert commented Apr 6, 2019

Aligning the option with CLI and Gradle Plugin, this keeps
skipValidateSpec and removes the redundant validateSpec.

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Aligning the option with CLI and Gradle Plugin, this keeps
`skipValidateSpec` and removes the redundant `validateSpec`.
@jimschubert
Copy link
Member Author

cc @wing328 @jmini

@wing328
Copy link
Member

wing328 commented Apr 9, 2019

The circle CI failure has been fixed in the master.

I've also marked this change as "Breaking changes with fallback"

@wing328 wing328 merged commit 76e444b into master Apr 9, 2019
@wing328 wing328 deleted the remove-validate-spec-from-maven-plugin branch April 9, 2019 09:14
jimschubert added a commit that referenced this pull request Apr 13, 2019
* master: (47 commits)
  [Slim] Fix AbstractAuthenticator constructor TypeError (#2641)
  Fix issue 1340 - StaticHtmlGenerator to allow snake_case property names (#2612)
  Test Gradle plugin in Appveyor CI (#2651)
  Add Camptocamp to company list (#2652)
  Use percent encoding for path parameters (#2649)
  Unescape HTML characters in JS docstring (#2636)
  [ONLINE] Minor links fix (#2644)
  better handling of undefined inner property in array (#2635)
  Fix regexp error on php-slim (#2604)
  [TypeScript-Fetch] Generate oneOf schemas as type unions (#2617)
  Add Namsor as the sponsor (#2639)
  fix classname in website (#2638)
  Code review fixes (#2633)
  Move Ruby module/gem to codegen constant (#2621)
  Add sponsor section to the website (#2634)
  [Spring] Spotbugs static class and default encoding (#2609)
  Add @Zomzog (2019/04) to Java, Kotlin tech comm (#2630)
  [maven] remove validateSpec (#2614)
  Clean up the license field in various templates to ensure it's unlicense by default. (#2627)
  Fix NPE when server url is null (#2628)
  ...
@wing328 wing328 added this to the 4.0.0 milestone Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants