Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ObjC reserved words only when objcCompatible is enabled #2632

Merged
merged 4 commits into from
Apr 15, 2019
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Apr 9, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #2589

cc @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @d-date (2018/03)

Copy link

@d-date d-date left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wing328 wing328 merged commit da9ba4c into master Apr 15, 2019
@wing328 wing328 deleted the objc_id branch April 15, 2019 07:35
@wing328
Copy link
Member Author

wing328 commented Apr 15, 2019

Upgrade Note

The following ObjC reserved words will only be included in the reserved word list when the "objcCompatible" option is enabled:

"id", "description", "NSArray", "NSURL", "CGFloat", "NSSet", "NSString", "NSInteger"
"NSUInteger", "NSError", "NSDictionary"

For example, _id will become just id for a Swift only client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [Swift] Property naming policy
2 participants