Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass opts argument to api client in ruby-client #2754

Merged
merged 5 commits into from
Apr 28, 2019

Conversation

ota42y
Copy link
Contributor

@ota42y ota42y commented Apr 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

Description of the PR

We want to change the option when debugging, changing timeout to specific api, etc...
So we want to merge and pass options to api client.

We want to change the option when debugging, changing timeout to specific api, etc...
So we want to merge and pass options to api client.
Copy link
Contributor

@autopp autopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ota42y This changes looks good to me!
I found typo, so please check.

@wing328
Copy link
Member

wing328 commented Sep 14, 2020

@ota42y thanks again for the PR. When you've time, I wonder if you can PM me via Slack or Twitter as I've some questions on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants