[elm] Fix repetitive enum prefixes #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
andys8
reviewed
May 1, 2019
| enumVar.put("name", prefix + enumVar.get("name")); | ||
| if (!enumVar.containsKey("_isPrefixed")) { | ||
| enumVar.put("name", prefix + enumVar.get("name")); | ||
| enumVar.put("_isPrefixed", true); |
There was a problem hiding this comment.
An idea for an alternative: Test if enumVar.get("name") already starts with prefix. I guess it needs also to be not equal to prefix to support prefixing type MyType = MyType. Would this actually work and make storing _isPrefixed obsolete?
There was a problem hiding this comment.
Thought of that as well, but I'd like to keep the prefix consistent.
andys8
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2759.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
For arrays of enums, the elm prefix is added four times, instead of once.
cc @wing328