Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about .net 2.0 framework reached EOL #2804

Merged
merged 1 commit into from
May 3, 2019
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 3, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add warning about .net 2.0 framework reached EOL

@jimschubert
Copy link
Member

I'd like to do this a little differently. I'll open a PR later today for feedback. Basically, I'm thinking about adding an 'isDeprecated' boolean to CodegenConfig. This will allow us to inform users of deprecated generators much earlier than at generation time, and allows us to display a warning in a centralized place.

I may also consider a more robust "State" object for metadata about the generator.

@wing328
Copy link
Member Author

wing328 commented May 3, 2019

Basically, I'm thinking about adding an 'isDeprecated' boolean to CodegenConfig. This will allow us to inform users of deprecated generators much earlier than at generation time, and allows us to display a warning in a centralized place.

Sure. Let's improve the depreciation notice bit by bit.

@wing328 wing328 merged commit e71eb30 into master May 3, 2019
@jimschubert jimschubert deleted the csharp2-warning branch May 4, 2019 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants